[PATCH] D93063: [LV] Disable epilogue vectorization for scalable VFs

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 08:20:13 PST 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5778
+  // vectors when the loop has a hint to enable vectorization for a given VF.
+  assert(!MainLoopVF.isScalable() && "scalable vectors not yet supported");
+
----------------
c-rhodes wrote:
> bmahjour wrote:
> > We can just return `Result` around line 5792 (please see suggestion below), then we don't need to change the check near line 9209.
> > We can just return `Result` around line 5792 (please see suggestion below), then we don't need to change the check near line 9209.
> 
> That makes more sense, cheers. Added a simple test as well.
I guess there is no reason why the tail can't still be vectorized with a fixed-width VF, but given the state of scalable loop-vec I don't think that is really something to worry about at this point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93063/new/

https://reviews.llvm.org/D93063



More information about the llvm-commits mailing list