[PATCH] D83636: omp: Make OMP tablegen more like all other tablegens.

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D83636#2448764 <https://reviews.llvm.org/D83636#2448764>, @thakis wrote:

> I do think this is valuable. I was about to land it, but some change landed hours before I got the lg here and rebasing took me longer than 15 minutes, and I haven't had time to look at it again since then. If you could do something like this for ACC and OMP, I think that'd be great. As mentioned on the other review, having includes of "cpp.inc" files in .h files looks very unusual.

I agree with the inclusion of .cpp.inc inclusion inside .h file. Since then we have more code generated by tablegen and the file is meant to be included by both cpp or .h file depending on which section of code you include. I don't think we are very far from your solution with D92955 <https://reviews.llvm.org/D92955> as I renamed the file. I'm happy to introduce the changes left in a further patch (after D92955 <https://reviews.llvm.org/D92955>) that would include ACC as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83636/new/

https://reviews.llvm.org/D83636