[PATCH] D91761: [FileCheck] Add check modifier capability

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added inline comments.


================
Comment at: llvm/test/FileCheck/check-literal.txt:46
+; INVALID{BADMODIFIER}: 6371, 6372,
+; CHECK-INVALID: no check strings found with prefix 'BADMODIFIER
+
----------------
jhenderson wrote:
> jhenderson wrote:
> > Should this be `'INVALID'`?
> Any reason, you're not testing the closing `'`?
Yes, as it ends with :' which I feel could be improved (either by just dropping the : or also adding a regex for modifiers as optional there, preference towards the former at the moment). So wanted to just rest the essential part here and have the update of error message in follow up as it could affect more tests (e.g., make this and it more directed changes).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91761/new/

https://reviews.llvm.org/D91761