[PATCH] D93115: LNT: Sort testsuites ascendingly

Tamar Christina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 06:45:05 PST 2020


tnfchris added inline comments.


================
Comment at: lnt/server/db/v4db.py:59
+        # Order testuites alphabetically to get groupings
+        self.testsuite = dict (sorted (self.testsuite.items()))
 
----------------
thopre wrote:
> Shouldn't you use an OrderedDict instead of dict to guarantee the ordering will be the same as when inserted?
>From what I understand, in Python 3, dict is guaranteed to keep order during insertion https://mail.python.org/pipermail/python-dev/2017-December/151283.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93115/new/

https://reviews.llvm.org/D93115



More information about the llvm-commits mailing list