[PATCH] D93114: LNT: fix broken relative redirect

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 06:38:54 PST 2020


thopre added a comment.

In the description:

has at some point -> had at some point

Would you happen to know the former wording? If not don't bother searching but if yes maybe you could quote it in the description



================
Comment at: lnt/server/ui/globals.py:45
+    Flask's default response makes URLs absolute before putting in the
+    Location header due to adhering to a typo the out-dated RFC 2616.
+
----------------
I don't quite understand this line but how about:

adhering to a typo the out-dated -> a misunderstanding of an ambiguous statement in a former version of RFC 2616


================
Comment at: lnt/server/ui/globals.py:47
+
+    The RFC was fixed by Flask still doesn't allow it by default.
+    """
----------------
by -> but
doesn't -> does not


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93114/new/

https://reviews.llvm.org/D93114



More information about the llvm-commits mailing list