[PATCH] D93033: [llvm-readobj] - For SHT_REL relocations, don't display an addend.

Fri Dec 11 06:31:27 PST 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Seems reasonable to me. I guess in some of the existing tests, they should be checking the addend in the relocated data, but if they don't already, we aren't making the situation worse. LGTM, with nits.

================
Comment at: llvm/test/MC/ARM/thumb-far-jump.s:27
+@ CHECK: 0x2004 R_ARM_THM_CALL main2
\ No newline at end of file

----------------
Nit: no new line at EOF.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/relr-relocs.test:15
+# RUN: llvm-readobj --relocations %t1 | \
+# RUN: FileCheck --match-full-lines --check-prefix=LLVM1 %s
+
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93033/new/

https://reviews.llvm.org/D93033