[PATCH] D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

In D92052#2448057 <https://reviews.llvm.org/D92052#2448057>, @burnus wrote:

> @jhenderson – did I answer your questions - or did I misread them? Are the other issues?

Apologies, I somehow missed this. LGTM once @MaskRay's outstanding comment has been addressed.



================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:1
+# RUN: llvm-mc -triple=x86_64 %s -o - | FileCheck %s
+
----------------
MaskRay wrote:
> Please add a file-level comment about the purpose of the test:
> 
> If section flags and other attributes are omitted, don't error.
It looks like @MaskRay's comment hasn't been addressed here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92052/new/

https://reviews.llvm.org/D92052