[PATCH] D93116: LNT: Use relative URLs for Javascript-based URLs.

Fri Dec 11 06:00:59 PST 2020

tnfchris created this revision.
tnfchris added a reviewer: thopre.
tnfchris requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Having _external=True seems to break links when LNT is hosted behind a
reverse-proxy. This has been observed previously as
https://reviews.llvm.org/D85425 for example.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93116

Files:
  lnt/server/ui/templates/layout.html


Index: lnt/server/ui/templates/layout.html
===================================================================

--- lnt/server/ui/templates/layout.html
+++ lnt/server/ui/templates/layout.html
@@ -3,7 +3,7 @@
 <head>
     <meta charset="UTF-8"/>
 
-    <script>var lnt_url_base="{{ url_for('.index', _external=True) }}".replace(/\/$/, "");</script>
+    <script>var lnt_url_base="{{ url_for('.index', _external=False) }}".replace(/\/$/, "");</script>
     <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css')
                 }}" rel="stylesheet" media="screen"/>
     <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93116.311205.patch
Type: text/x-patch
Size: 681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201211/68d4db38/attachment.bin>
