[PATCH] D93083: [InstCombine] Remove scalable vector restriction in foldSelectOpOp

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 01:24:38 PST 2020


sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:278
   Type *CondTy = Cond->getType();
   if (TI->getNumOperands() == 1 && TI->isCast()) {
     Type *FIOpndTy = FI->getOperand(0)->getType();
----------------
The test works already without this patch, so this change isn't actually tested.
(Because of `TI->isCast` here, I was expecting to see a cast instruction as one of the select operands)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93083/new/

https://reviews.llvm.org/D93083



More information about the llvm-commits mailing list