[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

Thu Dec 10 21:40:00 PST 2020

MaskRay added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:207
+  if (Cie == nullptr)
+    return createStringError(errc::illegal_byte_sequence,
+                             "unable to get CIE for FDE at offset 0x%" PRIx64,
----------------
jhenderson wrote:
> MaskRay wrote:
> > The description of illegal_byte_sequence (EILSEQ) is: Invalid or incomplete multibyte or wide character. It is about an encoding problem. Probably just use errc::invalid_argument
> @MaskRay, I thought that too, but I've been unable to find where the description comes from. Could you point me at it, please?
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html EILSEQ "Illegal byte sequence.". This is brief but in other pages in POSIX you can find descriptions like "The data obtained from the input stream does not form a valid character." "The wide-character code wc does not correspond to a valid character."

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845