[PATCH] D92965: [NFC] Remove unused prefixes in llvm/test/CodeGen/X86

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

> looks like quite a few (3K) of tests in CodeGen (14K or so) use it. So I wanted to understand why removing a prefix used nowhere in the test lead to an incorrect rewrite of some assertions.

There are more then 6K tests. update_llc_test_checks.py is just one of the update scripts.

> Separately, am I understanding update_llc_test.checks.py's usage accurately - IIUC, it's basically this:
>
> - write new RUN line. Add, to FileCheck, a list of prefixes to check
> - write functions
> - run update_llc_test.checs.py => it will add the pertinent asserts to the function(s) added above

In fact, I usually assign one prefix to RUN line at the beginning and run update script. If there are duplications, I will add a common prefix for them.
For tests have many RUNs and functions, I may do round and round updates to find a relatively optimized combination. Some prefixes may become unused without aware of. Some attempts are not correct, but I'm aware of them since the script will warn the conflict.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92965/new/

https://reviews.llvm.org/D92965