[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

Add initial author to have a review.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:296
           else:
-            if prefix == prefixes[-1]:
-              warn('Found conflicting asm under the same prefix: %r!' % (prefix,))
----------------
I didn't dig into it too much, but the code looks to me that if all prefixes for the func don't meet the condition (already iterated to the last one), it reports warnings to user.
It seems you just removed the warnings instead of fixing the problem. So users hardly be aware of there's real conflict on their prefixes lists on RUN command line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93078/new/

https://reviews.llvm.org/D93078