[PATCH] D93037: [YAML] Use correct source location for unknown key errors.

Nathan James via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 16:04:46 PST 2020


njames93 added a comment.

In D93037#2446301 <https://reviews.llvm.org/D93037#2446301>, @silvas wrote:

> Would be nice to find a way to test this (Maybe a FileCheck test? not sure how to set that up though; don't worry if it is too much work.)

Bit of a pain to set that up explicitly. Thankfully, there are 8 test failures(per platform) introduced by this patch that demonstrate the old unexpected behaviour.
Fixing those should be semi-decent basic coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93037/new/

https://reviews.llvm.org/D93037



More information about the llvm-commits mailing list