[PATCH] D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308)

Thu Dec 10 12:34:51 PST 2020

clementval added inline comments.

================
Comment at: flang/lib/Semantics/resolve-directives.cpp:878

-// 2.15.1.1 Data-sharing Attribute Rules - Predetermined
+// [OMP-4.5]2.15.1.1 Data-sharing Attribute Rules - Predetermined
 //   - A loop iteration variable for a sequential loop in a parallel
----------------
Not specially for this patch but just a quick question: What is the ultimate standard we are targeting in Flang? 4.5 or 5.0. I have seen both in new patches and since there is no way to enforce one standard or another it feel weird to mix them. Maybe I missed this discussion but if you have any information it would be great for my personal knowledge. 

================
Comment at: flang/lib/Semantics/resolve-directives.cpp:883
+// Loop iteration variables are not well defined for DD WHILE loop
+// in OpenMP-5.0 standard
+// Use of DO CONCURRENT inside OpenMP construct is unspecified behavior
----------------
First line reference 4.5 and here 5.0 .... I think it would be nice to have a homogeneity here. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92638/new/

https://reviews.llvm.org/D92638