[PATCH] D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS

Thu Dec 10 12:03:29 PST 2020

MaskRay added inline comments.

================
Comment at: lld/test/ELF/aarch64-variant_pcs.s:18
+# PCSSYM:        0 IFUNC  GLOBAL DEFAULT [VARIANT_PCS]   7 pcs_ifunc_global_def
+# PCSSYM: Symbol table '.symtab'
+# PCSSYM:        0 NOTYPE LOCAL  DEFAULT [VARIANT_PCS]   7 pcs_func_local
----------------
zatrazz wrote:
> psmith wrote:
> > Maybe worth not including the static symbol table in the test; while there is nothing wrong with keeping the variant pcs flag in the static symbol table, I don't think it is required for an executable or shared library.
> Right, I will add only the GLOBAL ones then.
I think testing `.symtab` is fine and probably favorable because otherwise local symbols cannot be tested. While their values are useful to ld.so, their values could be read by programs performing reflection and other binary manipulating programs. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93045/new/

https://reviews.llvm.org/D93045