[PATCH] D91878: [CSSPGO] Pseudo probe encoding and emission.

[Hongtao Yu via Phabricator via llvm-commits]

hoy marked an inline comment as done.
hoy added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp:65
+        InlinedAt->getDiscriminator());
+    ReversedInlineStack.push_back({CallerGuid, CallerProbeId});
+    InlinedAt = InlinedAt->getInlinedAt();
----------------
craig.topper wrote:
> This line doesn't compile with gcc 5.4
> 
> ```
> llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp:65:62: error: converting to ‘std::tuple<long unsigned int, unsigned int>’ from initializer list would use explicit constructor ‘constexpr std::tuple<_T1, _T2>::tuple(_U1&&, _U2&&) [with _U1 = long unsigned int&; _U2 = long unsigned int&; <template-parameter-2-3> = void; _T1 = long unsigned int; _T2 = unsigned int]’
>      ReversedInlineStack.push_back({CallerGuid, CallerProbeId})
> ```
> 
> Changing it to emplace_back and dropping the curly braces seemed to work.
Thanks for the suggestion! Fix pushed in just now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91878/new/

https://reviews.llvm.org/D91878