[PATCH] D91878: [CSSPGO] Pseudo probe encoding and emission.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 11:24:21 PST 2020


hoy added a comment.

In D91878#2446557 <https://reviews.llvm.org/D91878#2446557>, @hoy wrote:

> In D91878#2446515 <https://reviews.llvm.org/D91878#2446515>, @mehdi_amini wrote:
>
>> This breaks the build with gcc5:
>>
>>   llvm/lib/MC/MCParser/AsmParser.cpp:5836:49: error: converting to 'llvm::InlineSite {aka std::tuple<long unsigned int, unsigned int>}' from initializer list would use explicit constructor 'constexpr std::tuple<_T1, _T2>::tuple(_U1&&, _U2&&) [with _U1 = long int&; _U2 = long int&; <template-parameter-2-3> = void; _T1 = long unsigned int; _T2 = unsigned int]'
>>        InlineSite Site = {CallerGuid, CallerProbeId};
>
> Thanks for reporting the issue.  I will change to use an explicit constructor.

Fixed by changing to `InlineSite Site(CallerGuid, CallerProbeId);`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91878/new/

https://reviews.llvm.org/D91878



More information about the llvm-commits mailing list