[PATCH] D82005: [InstCombine] Replace selects with Phis

Thu Dec 10 10:51:44 PST 2020

spatel added a comment.

In D82005#2446264 <https://reviews.llvm.org/D82005#2446264>, @spatel wrote:

> In D82005#2445338 <https://reviews.llvm.org/D82005#2445338>, @uabelho wrote:
>
>> Note the use of %0 in f.exit, which is not reachable from entry.
>
> This looks similar to the problem in 94f6d365 <https://reviews.llvm.org/rG94f6d365e4be0cf05930df0eedd2bfb23f6fce51> ( https://llvm.org/PR48369 ). I'll take a look.

This should handle the test shown: 4f051fe <https://reviews.llvm.org/rG4f051fe37438632d10480c346520a0de624dbebf>
If there are still variations of this bug present, we might want to try a different fix in instcombine and/or domtree.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82005/new/

https://reviews.llvm.org/D82005