[PATCH] D88589: [DebugInfo] Handle dbg.values with multiple variable location operands in ISel
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 10 08:52:58 PST 2020
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Mechanically this looks fine.
================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1546
+ /// Creates a SDDbgValue node from a list of locations.
+ SDDbgValue *getDbgValueList(DIVariable *Var, DIExpression *Expr,
----------------
It would be nice if we can find a less overloaded term than "locations". Perhaps just call them straight `DW_OP_LLVM_args`?
================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1499
+ ArrayRef<SDNode *> Dependencies, bool IsIndirect,
+ const DebugLoc &DL, unsigned O, bool IsVariadic);
+
----------------
is IsVariadic the same as `Locs.size() > 1`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88589/new/
https://reviews.llvm.org/D88589
More information about the llvm-commits
mailing list