[PATCH] D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 08:48:38 PST 2020


aprantl added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2591
+  /// (0 and 1).
+  uint64_t getLocationOperandCount() const;
+
----------------
to be in line with the other method names: `getNumLocationOperands()` or `getNumLocationRefs()` or `getNumArgOps()`...?
If wee get super nerdy, I think technically these are operators (that operate on the DWARF stack) and not operands :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91722/new/

https://reviews.llvm.org/D91722



More information about the llvm-commits mailing list