[PATCH] D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null

Thu Dec 10 07:38:45 PST 2020

epastor added a comment.

In D90061#2431150 <https://reviews.llvm.org/D90061#2431150>, @thakis wrote:

> Still no test, as far as I can tell. I think the suggestion below turns this into a 3-line diff (+ test).

Tests added, thanks.

================
Comment at: llvm/tools/llvm-ml/Opts.td:48
                              "the .asm extension">;
+def parse_only : MLFlag<"Zs">, HelpText<"Run a syntax-check only">;

----------------
thakis wrote:
> Instead of all the DerivedArgList changes below, doesn't just saying `..., Alias<filetype>, AliasArgs<"none">` here do the same thing?
... yes, and I didn't know that was an option. Fixed - though it did require me to move these below the LLVM-style args, so we could successfully alias it to one of them.

Thanks, this is much better!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90061/new/

https://reviews.llvm.org/D90061