[PATCH] D92970: [flang] Fix bogus message on index-names in the presence of associated entities

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Evaluate/tools.cpp:939
 
+Symbol *GetAssociationRoot(Symbol &symbol) {
+  return const_cast<Symbol *>(
----------------
klausler wrote:
> The body of this overridden function should be next to the original, no?
> 
> Consider using `const_cast` on a reference type rather than a created pointer.
Thanks, Peter.  I'll make these changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92970/new/

https://reviews.llvm.org/D92970