[PATCH] D93033: [llvm-readobj] - For SHT_REL relocations, don't display an addend.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 07:13:26 PST 2020


arichardson added a comment.

Thanks, this is a lot less confusing that printing 0. Ideally, we'd read the REL addend from the offset, but that's obviously a lot more effort.

My only concern about removing the 0x0 from the CHECK lines is that these tests will still pass if we do add support for reading REL addends. I see that many of the tests now contain `{{$}}`, maybe add this for all of them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93033/new/

https://reviews.llvm.org/D93033



More information about the llvm-commits mailing list