[PATCH] D92766: [XCOFF][AIX] Emit EH information in traceback table

[Digger via Phabricator via llvm-commits]

DiggerLin added a comment.

no further comment on it . It just need to rebased after



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:73
+  const Function *Per =
+      dyn_cast<Function>(F.getPersonalityFn()->stripPointerCasts());
   const MCSymbol *PerSym = Asm->TM.getSymbol(Per);
----------------
jasonliu wrote:
> DiggerLin wrote:
> > Constant *Function::getPersonalityFn() const {
> >   assert(hasPersonalityFn() && getNumOperands());
> >   return cast<Constant>(Op<0>());
> > }
> > 
> > do we need the 
> > assert(F.hasPersonalityFn() &&
> >          "Landingpads are presented, but no personality routine is found."); 
> > once more ?
> It helps to tell exactly what went wrong in this context. i.e. landingpad presents, but no personality routine gets us here.
> But if you think it's really redundant, I could remove it. 
it is ok for me


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2131
+  return MF->getMMI().getContext().getOrCreateSymbol(
+      "__ehinfo." + Twine(MF->getFunctionNumber()));
+}
----------------
it means there will be same symbol name in the different translation unit ? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92766/new/

https://reviews.llvm.org/D92766