[PATCH] D91174: [Support] Introduce a new InstructionCost class

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau added a comment.

Please add the asserts in SLPVectorizer, and then this looks good to me.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3797-3808
+              *(TTI->getInstructionCost(I, CostKind).getValue());
         }
         for (Value *V : VL) {
           Instruction *I = cast<Instruction>(V);
-          ReuseShuffleCost += TTI->getInstructionCost(I, CostKind);
+          ReuseShuffleCost +=
+              *(TTI->getInstructionCost(I, CostKind).getValue());
         }
----------------
NIT: If we're adding an assert in LoopVectorize, then these three getValues should also get asserts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91174/new/

https://reviews.llvm.org/D91174