[PATCH] D93000: [lld-macho] Implement `-no_implicit_dylibs`

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks! I'll patch this in and verify if it fixes PR48395



================
Comment at: lld/MachO/Config.h:39
   bool staticLink = false;
+  bool noImplicitDylibs = false;
   bool isPic = false;
----------------
nit: Because double negation is confusing, naming booleans always for the positive variant ("enableFoo" instead of "disableFoo" etc) tends to make for more readable code. Can we name this `implictDylibs`? It doesn't make a huge difference for readability in this case, but not having negated booleans is a good general guideline imho.


================
Comment at: lld/MachO/InputFiles.cpp:512
+// library.
+static bool implicitlyLinked(StringRef path) {
+  if (config->noImplicitDylibs)
----------------
nit: `isImplicitlyLinked` or `shouldImplicitlyLink`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93000/new/

https://reviews.llvm.org/D93000