[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added inline comments.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:833
+    }
+  }
   pass &= AArch64::getCPUAttr(AK).equals(CPUAttr);
----------------
MarkMurrayARM wrote:
> DavidSpickett wrote:
> > I assume this was left in from debugging, if not it should be its own change.
> > (considering this file is already using gtest, you could refactor to ASSERT_EQ the flags and get the messages for free)
> I like the idea of ASSERT_EQ, but I need the numbers to be in hex.
(assuming llvm's copy of GTest supports it)
https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#using-a-predicate-formatter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93022/new/

https://reviews.llvm.org/D93022