[PATCH] D91761: [FileCheck] Add check modifier capability

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 05:28:06 PST 2020


jpienaar marked an inline comment as done.
jpienaar added inline comments.


================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:1662-1663
+      -> std::pair<Check::FileCheckType, StringRef> {
+    if (Rest.consume_front(":"))
+      return {Ret, Rest};
+    if (!Rest.consume_front("{"))
----------------
jhenderson wrote:
> Can you get rid of this check now?
No because these are used by CHECK-NEXT and the rest, so I would need to repeat this for each of them there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91761/new/

https://reviews.llvm.org/D91761



More information about the llvm-commits mailing list