[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

Mikhail Maltsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 04:27:13 PST 2020


miyuki added inline comments.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:47
+    if (!pass)
+      std::cout << "ExpectedFlags = 0x" << std::hex << ExpectedFlags
+        << " do not equal ExtKind = 0x" << std::hex << ExtKind
----------------
I suggest using LLVM I/O facilities instead of std::cout and stderr instead of stdout. E.g.
```
#include "llvm/Support/raw_ostream.h"
#include "llvm/Support/Format.h"
//...
errs() << "ExpectedFlags = " << format_hex(ExpectedFlags, 8) <<
//...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93022/new/

https://reviews.llvm.org/D93022



More information about the llvm-commits mailing list