[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 04:10:56 PST 2020


DavidSpickett added inline comments.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:833
+    }
+  }
   pass &= AArch64::getCPUAttr(AK).equals(CPUAttr);
----------------
I assume this was left in from debugging, if not it should be its own change.
(considering this file is already using gtest, you could refactor to ASSERT_EQ the flags and get the messages for free)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93022/new/

https://reviews.llvm.org/D93022



More information about the llvm-commits mailing list