[PATCH] D93021: [llvm-readelf/obj] - Minor cleanup of warning reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 03:25:32 PST 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added a subscriber: rupprecht.
grimar requested review of this revision.
Herald added a project: LLVM.

This:

1. Removes the `reportUniqueWarning` overload that accepts `Error Err`.

We can live with the version that accepts `const Twine &` and
anyways warnings reported in many places touched by this patch can probably
be improved. To do that we would need to use `Twine` version anyways.

2. Converts the last `reportWarning` in `ELFDumper.cpp` to `reportUniqueWarning`.

In that place it is a no-op I believe.


https://reviews.llvm.org/D93021

Files:
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93021.310822.patch
Type: text/x-patch
Size: 12671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201210/550004bc/attachment.bin>


More information about the llvm-commits mailing list