[PATCH] D92819: [TruncInstCombine] Remove scalable vector restriction

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 01:09:59 PST 2020


junparser added inline comments.


================
Comment at: llvm/test/Transforms/AggressiveInstCombine/trunc_const_expr.ll:120
+  %T = trunc <vscale x 2 x i64> %A to <vscale x 2 x i32>
+  call <vscale x 2 x i32> @use32_scale_vec(<vscale x 2 x i32> %T)
+  ret void
----------------
sdesmalen wrote:
> nit: instead of calling some `@use32_scale_vec`, could it simply be returned?
Yes, we can. However, I prefer to keep the call in case when we can represent more vscale constant vector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92819/new/

https://reviews.llvm.org/D92819



More information about the llvm-commits mailing list