[PATCH] D92641: [llvm-readelf/obj] - Handle out-of-order PT_LOADs better.
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Dec 10 01:08:58 PST 2020
    
    
  
jhenderson added inline comments.
================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:377
+
+    EXPECT_TRUE((bool)DataOrErr);
+    EXPECT_TRUE(WarnString ==
----------------
I think if `DataOrErr` is false, we need to somehow handle the error, right? Actually maybe this should just be `ASSERT_TRUE`?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92641/new/
https://reviews.llvm.org/D92641
    
    
More information about the llvm-commits
mailing list