[PATCH] D91761: [FileCheck] Add check modifier capability

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:1662-1663
+      -> std::pair<Check::FileCheckType, StringRef> {
+    if (Rest.consume_front(":"))
+      return {Ret, Rest};
+    if (!Rest.consume_front("{"))
----------------
Can you get rid of this check now?


================
Comment at: llvm/test/FileCheck/check-literal.txt:45
+
+; INVALID{LITTERAL}: 6371, 6372,
+; CHECK-INVALID: no check strings found with prefix 'INVALID
----------------
Sorry, I was referring to the `{LITTERAL}` bit actually :)

The single character difference to `LITERAL` makes it look like there's a typo, and not a deliberate decision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91761/new/

https://reviews.llvm.org/D91761