[PATCH] D92933: [ARM][MachineOutliner] Handle stack usage.
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 10 00:35:03 PST 2020
samparker added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5823
+ // outline this by saving all of its bytes.
+ else
+ NumBytesNoStackCalls += SequenceSize;
----------------
We were returning here previously, and now it's possible that there's a Candidate that hasn't been inserted into CandidatesWithoutStackFixups. When we update RepeatedSequences on line 5832, are we guaranteed to have not missed some candidates?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92933/new/
https://reviews.llvm.org/D92933
More information about the llvm-commits
mailing list