[PATCH] D92706: [coroutine] should disable inline before calling coro split

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Transforms/Coroutines/coro-inline.ll:1
+; RUN: opt < %s -always-inline -barrier -coro-early -barrier -coro-split -S | FileCheck %s
+; RUN: opt < %s -enable-new-pm  -always-inline -coro-early -coro-split  -S | FileCheck %s
----------------
Are these `-barrier`s necessary? The test passes without them. And no other test in all of LLVM uses it.


================
Comment at: llvm/test/Transforms/Coroutines/coro-inline.ll:2
+; RUN: opt < %s -always-inline -barrier -coro-early -barrier -coro-split -S | FileCheck %s
+; RUN: opt < %s -enable-new-pm  -always-inline -coro-early -coro-split  -S | FileCheck %s
+; RUN: opt < %s -sample-profile-file=%S/Inputs/sample.text.prof -pgo-kind=pgo-sample-use-pipeline -coro-early -barrier -sample-profile -barrier -coro-split  -disable-inlining=true -S | FileCheck %s
----------------
`-enable-new-pm` shouldn't be used to run the NPM, this should be something like `-passes=always-inline,coro-early,coro-split`.


================
Comment at: llvm/test/Transforms/Coroutines/coro-inline.ll:32
+
+!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, producer: "", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2)
+!1 = !DIFile(filename: "inline_O2.cpp", directory: "")
----------------
seems like this test should be reduced, is any of this debug info metadata necessary for the test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92706/new/

https://reviews.llvm.org/D92706