[PATCH] D92974: [OpenMPIRBuilder] Implement tileLoops.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

Thanks for the patch! Some NIT's related to refactoring/moving inline. I've tried to highlight some parts, if you like the idea in general, there might be more opportunities to reduce the size of this patch(thus capturing the most crucial part `tileLoop`).



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:701
+
+  /// Create the control flow structure of a canonical OpenMP loop.
+  ///
----------------
NIT: Would it make sense to do this as a separate maybe (NFCI) patch ? FWIW it will reduce the size of this patch.
WDYT?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:775
+  /// by getBody().
+  void colleckControlBlocks(SmallVectorImpl<BasicBlock *> &BBs);
 
----------------
colleck... Typo ?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:829
 
+  /// Return the type of the induction variable (and the trip count).
+  Type *getIndVarType() const { return getIndVar()->getType(); }
----------------
NIT: these helper functions can also be moved, as mentioned in above comment,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92974/new/

https://reviews.llvm.org/D92974