[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:33
+constexpr uint8_t AllocRegNo = 31;
+constexpr uint8_t WidthOfParmTypeMask = 2;
 
----------------
Seems weird to me that this is not defined as part of `TracebackTable`.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1775
+  // There is a lack of information in the IR to assist with determining the
+  // source language, We use C++ as Language here.
+  TracebackTable::LanguageID LanguageIdentifier =
----------------
We use C++ as the Language here because ...? Please ask @jasonliu if help is needed on the explanation.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1758
+  std::string CommentString;
+  raw_string_ostream CommentOS(CommentString);
+
----------------
DiggerLin wrote:
> hubert.reinterpretcast wrote:
> > I don't think a `std::string` in needed here; using `raw_svector_ostream` should work.
> using raw_svector_ostream here. it need SmallString ,  for example.
> SmallString<128> InstPrinterStr; 
>     raw_svector_ostream OSS(InstPrinterStr);
> 
> if you think we need to raw_svector_ostream  , I can move to raw_svector_ostream.  
Yes, please make that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398