[PATCH] D92965: [NFC] Remove unused prefixes in llvm/test/CodeGen/X86

Wed Dec 9 20:02:17 PST 2020

mtrofin added a comment.

In D92965#2444553 <https://reviews.llvm.org/D92965#2444553>, @pengfei wrote:

> I left about 12 tests when I fixed the prefixes issues using the script, because the changes on prefixes will resulted in conflict when re-generating them. I suspected if it is a bug in update_llc_test_checks.py, but I didn't find time to look through. Maybe we can add `--allow-unused-prefixes=false` for these failed tests as a workaround?

I actually just undid the re-generation changes, leaving just the unused prefix removal. I'm not sure what the pros/cons to re-generation would be - my reasoning was about "keeping this change scoped". The tests passed, though with a FileCheck with the flag flipped to not allow unused prefixes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92965/new/

https://reviews.llvm.org/D92965