[PATCH] D92952: [WebAssembly] Support COMDAT sections in assembly syntax

[Derek Schuff via Phabricator via llvm-commits]

dschuff created this revision.
Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100.
dschuff updated this revision to Diff 310706.
dschuff added a comment.
dschuff retitled this revision from "[WIP][WebAssembly] Support COMDAT sections in assembly" to "[WebAssembly] Support COMDAT sections in assembly syntax".
dschuff edited the summary of this revision.
dschuff added reviewers: sbc100, aardappel.
dschuff published this revision for review.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Fix up


dschuff added a comment.

This is ready to review now.


This CL changes the asm syntax for section flags, making them more like ELF

  (previously "passive" was the only option). Now we also allow "G" to designate
  COMDAT group sections. In these sections we set the appropriate comdat flag on
  function symbols, and also avoid auto-creating a new section for them.
  
  This also adds asm-based tests for the changes D92691 to go along with
  the direct-to-object tests.
  
  Differential Revision: https://reviews.llvm.org/D92952


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92952

Files:
  llvm/lib/MC/MCParser/WasmAsmParser.cpp
  llvm/lib/MC/MCSectionWasm.cpp
  llvm/lib/MC/WasmObjectWriter.cpp
  llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  llvm/test/MC/WebAssembly/comdat-asm.ll
  llvm/test/MC/WebAssembly/comdat-sections.ll
  llvm/test/MC/WebAssembly/comdat-sections.s
  llvm/test/MC/WebAssembly/comdat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92952.310706.patch
Type: text/x-patch
Size: 12643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201210/9ec00dc2/attachment.bin>