[PATCH] D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1357
+  // Skip debug declarations, we don't want a DebugLoc from them.
+  MBBI = skipDebugInstructionsForward(std::prev(MBBI), instr_rend());
+  if (MBBI != instr_rend())
----------------
RKSimon wrote:
> craig.topper wrote:
> > Is it possible MBBI is already at instr_rend() so that std::prev isn't valid?
> @myhsu Have you confirmed whether this can happen? It looks like it at least needs an assert, else an early-out.
sorry I missed this comment. I've just fixed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88386/new/

https://reviews.llvm.org/D88386