[PATCH] D92970: [flang] Fix bogus message on index-names in the presence of associated entities

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 14:11:51 PST 2020


klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Evaluate/tools.cpp:939
 
+Symbol *GetAssociationRoot(Symbol &symbol) {
+  return const_cast<Symbol *>(
----------------
The body of this overridden function should be next to the original, no?

Consider using `const_cast` on a reference type rather than a created pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92970/new/

https://reviews.llvm.org/D92970



More information about the llvm-commits mailing list