[PATCH] D92690: [MC][AMDGPU] Consume EndOfStatement in asm parser

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 11:19:47 PST 2020


scott.linder added a comment.

In D92690#2442357 <https://reviews.llvm.org/D92690#2442357>, @dp wrote:

> I'd have reverted to using IDLoc because the error message is clear enough.
> I'm sorry that my change caused such trouble.
> The better is the enemy of the good :-)

That makes sense to me, I probably should have asked first :^)

I also realized after having slept on it that my current patch doesn't work for any non-ascii input anyway.

I will just revert that part of your earlier change and put up a review for it separately, then this patch should rebase cleanly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92690/new/

https://reviews.llvm.org/D92690



More information about the llvm-commits mailing list