[PATCH] D92946: [AMDGPU] Mark amdgpu_gfx functions as module entry function

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:939-940
+              AMDGPU::isEntryFunctionCC(Callee->getCallingConv())) {
+            report_fatal_error("invalid call to entry function");
+            llvm_unreachable("callee should have been handled before caller");
+          }
----------------
One or the other error methods


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.h:51
 
+  // If the function is allowed to allocate LDS global objects.
+  bool IsModuleEntryFunction = false;
----------------
Naming is a bit weird for the comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92946/new/

https://reviews.llvm.org/D92946