[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1779
+
+  uint32_t FirstHalfOfMandatoryField = 0;
+
----------------
Please add at least a comment that this is only populated for the third and fourth bytes.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1788
+  if (MF->getFunction().hasInternalLinkage())
+    FirstHalfOfMandatoryField |= TracebackTable::IsInternalProcedureMask;
+
----------------
jasonliu wrote:
> I'm not sure what internal procedure means here. But it seems xlC/xlclang compilers does not set it for static functions. 
> So should we error on the safe side and not set it as well?
Just for information: an "internal procedure" in this context is one that does not manipulate the stack pointer. Procedures that fit this description nevertheless don't have the flag set by `xlc`, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398