[PATCH] D92589: Introduce new option -print-changed-only and associated change printer.

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 09:50:21 PST 2020


jamieschmeiser added a comment.

I was thinking about a slightly different approach for these options.  There are several different options (-print-changed, print-changed-diff, -dot-cfg-changed ) with different variations.  As you say, it doesn't make sense to use more than one at a time so I was thinking that perhaps there could be -print-changed, and -print-changed-options=<options>.  Without -print-changed-options, you would get this one (ie, before and after without banners for no changed, ignored, etc).  The options would be a string of characters v being verbose (all banners), b is -print-before-changed, p is patch format (-print-changed-diff which could also have a verbose mode as currently up for review and default to skipping other banners).  -dot-cfg-changed (also with/without verbose mode) would be d=string, b=string, a=string, c=string with strings going to the end of input or comma where d, b, a and c being the directory, before colour, after colour and common colour.  The option letters can change, the important thing is the idea of the first option saying you want some form of change reporter (defaulting to this nonverbose print-changed version) and a modifier option that picks and controls the various types of reporter.  WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92589/new/

https://reviews.llvm.org/D92589



More information about the llvm-commits mailing list