[PATCH] D92881: scudo: Fix quarantine allocation when MTE enabled.
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 09:39:22 PST 2020
hctim accepted this revision.
hctim added inline comments.
This revision is now accepted and ready to land.
================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:103
+ // user allocation.
+ if (UNLIKELY(Allocator.useMemoryTagging()))
+ storeTags(reinterpret_cast<uptr>(Ptr),
----------------
Are we sticking `UNLIKELY` around any memtag branches at this point? I feel like this might be a pain to undo when we actually have production devices that ship with this branch. Does it provide us a significant benefit?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92881/new/
https://reviews.llvm.org/D92881
More information about the llvm-commits
mailing list