[PATCH] D92918: [llvm-link][NFC] Minor cleanup
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 09:29:43 PST 2020
tra added a comment.
> llvm::Linker::linkModules() is a static member, so there is no need
> to pass reference to llvm::Linker instance to loadArFile() function.
I think you are relying on implementation details here. All you know within the `llvm-link.cpp` is that you're operating on an instance of class `Linker`. How it's implemented and whether `Linker::linkModules` happens to be a static member may change at any point in time.
Eliminating one function argument does not buy us anything here, as far as I can see.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92918/new/
https://reviews.llvm.org/D92918
More information about the llvm-commits
mailing list