[PATCH] D92736: [lld/mac] Use xxhash instead of MD5 for computing the UUID
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 08:26:32 PST 2020
thakis added a comment.
In D92736#2441709 <https://reviews.llvm.org/D92736#2441709>, @int3 wrote:
> I'd rather we not add compatibility options unless we discover it's actually necessary. I'm okay going with the xxhash for now, though personally I think it wouldn't hurt to set the bits to pretend that it's an MD5 hash-based UUID (as opposed to e.g. a timestamp UUID). I could see some tools caring about whether it's a timestamp vs a hash, but I think it's less likely that they would care about the exact hashing algorithm used. (RFC 4122 only specifies representations for MD5 and SHA1 hashes, so we can't represent xxhash.)
Makes sense. Put back the bits to claim that this is MD5. Please take another look :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92736/new/
https://reviews.llvm.org/D92736
More information about the llvm-commits
mailing list