[PATCH] D92844: [gn build] Link with -Wl,--gdb-index

Wed Dec 9 07:55:54 PST 2020

thakis added a comment.

In D92844#2441259 <https://reviews.llvm.org/D92844#2441259>, @aeubanks wrote:

> I'm confused on the term "release build". I typically use `is_optimized = true` and `is_debug = true` to get reasonably fast binaries but with backtraces for crashes (I work with a lot of crashes). Which `= false` does a "release build" refer to?

Will replace "release" with "no-debug-information".

> 15% slower links seems noticeable. I'd prefer putting this behind a flag (can default to `is_debug` if you really want). I think putting all optional compiler/linker command line flags behind gn args makes sense.

You're setting `is_debug=true` but you don't run the binary under gdb? If so, wy do you set `is_debug=true`? For stacks with line numbers?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92844/new/

https://reviews.llvm.org/D92844